linux-kernel - [PATCH][next] btrfs: remove redundant assignment to pointer node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241002163658.957316-1-colin.i.king@gmail.com>
Date: Wed,  2 Oct 2024 17:36:58 +0100
From: Colin Ian King <colin.i.king@...il.com>
To: Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>,
	David Sterba <dsterba@...e.com>,
	linux-btrfs@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH][next] btrfs: remove redundant assignment to pointer node

The pointer node is being assigned a value that is never read, the
jump back to label 'again' re-assigns node to the return value from
the call to  btrfs_get_delayed_node. The assignment is redundant
and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 fs/btrfs/delayed-inode.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index 508bdbae29a0..4d37ed88c856 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -154,7 +154,6 @@ static struct btrfs_delayed_node *btrfs_get_or_create_delayed_node(
 		/* Somebody inserted it, go back and read it. */
 		xa_unlock(&root->delayed_nodes);
 		kmem_cache_free(delayed_node_cache, node);
-		node = NULL;
 		goto again;
 	}
 	ptr = __xa_store(&root->delayed_nodes, ino, node, GFP_ATOMIC);
-- 
2.39.5