linux-kernel - Re: [PATCH v4 20/39] x86/resctrl: Change mon_event_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08375d83-623d-4baf-a0d9-10f7d31675cc@arm.com>
Date: Wed, 2 Oct 2024 17:58:26 +0100
From: James Morse <james.morse@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Fenghua Yu <fenghua.yu@...el.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 H Peter Anvin <hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
 shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>
Subject: Re: [PATCH v4 20/39] x86/resctrl: Change
 mon_event_config_{read,write}() to be arch helpers

Hi Reinette,

On 14/08/2024 05:02, Reinette Chatre wrote:
> On 8/2/24 10:28 AM, James Morse wrote:
>> @@ -1617,14 +1612,15 @@ static void mon_event_config_read(void *info)
>>       mon_info->mon_config = msrval & MAX_EVT_CONFIG_BITS;
>>   }
>>   -static void mondata_config_read(struct rdt_mon_domain *d, struct mon_config_info
>> *mon_info)
>> +static void mondata_config_read(struct resctrl_mon_config_info *mon_info)
>>   {
>> -    smp_call_function_any(&d->hdr.cpu_mask, mon_event_config_read, mon_info, 1);
>> +    smp_call_function_any(&mon_info->d->hdr.cpu_mask,
>> +                  resctrl_arch_mon_event_config_read, mon_info, 1);
>>   }
>>     static int mbm_config_show(struct seq_file *s, struct rdt_resource *r, u32 evtid)
>>   {
>> -    struct mon_config_info mon_info = {0};
>> +    struct resctrl_mon_config_info mon_info = {0};
>>       struct rdt_mon_domain *dom;
>>       bool sep = false;
>>   
> 
> Patch looks good, just a fyi:
> https://lore.kernel.org/lkml/b2ebc809c8b6c6440d17b12ccf7c2d29aaafd488.1720868538.git.christophe.jaillet@wanadoo.fr

Right - I'll pick that as prerequisite so that it rebases out neatly.


Thanks,

James