linux-kernel - Re: [PATCH] ASoC: amd: acp: drop bogus NULL check from i2s_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172789067550.163279.13765967937832147149.b4-ty@kernel.org>
Date: Wed, 02 Oct 2024 18:37:55 +0100
From: Mark Brown <broonie@...nel.org>
To: Liam Girdwood <lgirdwood@...il.com>, 
 Murad Masimov <m.masimov@...ima.ru>
Cc: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
 Venkata Prasad Potturu <venkataprasad.potturu@....com>, 
 Muhammad Usama Anjum <usama.anjum@...labora.com>, 
 Syed Saba Kareem <Syed.SabaKareem@....com>, 
 Vijendar Mukunda <Vijendar.Mukunda@....com>, linux-sound@...r.kernel.org, 
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] ASoC: amd: acp: drop bogus NULL check from
 i2s_irq_handler

On Tue, 01 Oct 2024 22:08:39 +0300, Murad Masimov wrote:
> When i2s_irq_handler is called, it's guaranteed that adata is not NULL,
> since IRQ handlers are guaranteed to be provided with a valid data pointer.
> Moreover, adata pointer is being dereferenced right before the NULL check,
> which makes the check pointless, even if adata could be NULL.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: acp: drop bogus NULL check from i2s_irq_handler
      commit: 8cd4e1f087b6906bacbbf8b637cac4e479a9cb34

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark