linux-kernel - Re: [PATCH v2 net] net: Fix an unsafe loop on the list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F4920F6D-1BE9-4268-8301-B69368DD2E1D@yadro.com>
Date: Wed, 2 Oct 2024 17:53:18 +0000
From: Anastasia Kovaleva <a.kovaleva@...ro.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>, "linux@...ro.com"
	<linux@...ro.com>
Subject: Re: [PATCH v2 net] net: Fix an unsafe loop on the list

On Wed, 2 Oct 2024 06:02:40 -0700 Jakub Kicinski wrote:
> Could you add a selftest? Should be fairly easy using YNL, ncdevmem is
> the only user so far.

Thank you for your review.

Originally I've stumbled upon this bug while developing a functionality in the
iscsit driver to inform the userspace about a failed iscsi session
authentication. I am not familiar with the netdev test tools; with YNL and
ncdevmem particularly. The change seems trivial enough. It fixes an obvious bug
with the deletion of an element of a list that you are currently iterating
over. I assume that it wasn’t reproduced often because there are few users of
the genetlink and usually there is no listeners of a family while removing a
driver that uses it.

If it is really necessary, it would take me a couple of days to make a test. If
not, I can send a v3 patch that just removes a trailing \.