linux-kernel - Re: [PATCH v2] printk: Improve memory usage logging during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zv2LQLsIC1y0bCDL@google.com>
Date: Wed, 2 Oct 2024 11:04:48 -0700
From: Isaac Manjarres <isaacmanjarres@...gle.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>, surenb@...gle.com,
	kernel-team@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] printk: Improve memory usage logging during boot

On Tue, Oct 01, 2024 at 05:46:31PM +0200, Petr Mladek wrote:
> On Mon 2024-09-30 11:48:24, Isaac J. Manjarres wrote:
> > With the new logs, it is much easier to see exactly why the memory
> > increased by 2304 KB:
> > 
> > log_buf_len=512K:
> > 
> > printk: log_buf_len: 524288 bytes
> > printk: prb_descs size: 393216 bytes
> > printk: printk_infos size: 1441792 bytes
> 
> This should get updated to the new format.
> If I count correctly then it should be:
> 
> printk: log buffer data + meta data: 524288 + 1835008 = 2359296 bytes
Sorry, I forgot to do that; thanks for catching it. Yes, the
calculation is correct.

> > Memory: ... (... 733252K reserved ...)
> > 
> > log_buf_len=1M:
> > 
> > printk: log_buf_len: 1048576 bytes
> > printk: prb_descs size: 786432 bytes
> > printk: printk_infos size: 2883584 bytes
> 
> and here:
> 
> printk: log buffer data + meta data: 1048576 + 3670016 = 4718592 bytes
This is also correct.

> > Memory: ... (... 735556K reserved ...)
> >
> > Signed-off-by: Isaac J. Manjarres <isaacmanjarres@...gle.com>
> 
> Otherwise, it looks good. With the updated commit message:
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>
> Tested-by: Petr Mladek <pmladek@...e.com>
> 
> 
> Note need to send v3. I could update the commit message when committing
> the patch.
> 
> I am going to wait few days for a potential another review
> before pushing.
Thank you Petr for your review and for picking this up! I really
appreciate it.

Thanks,
Isaac