linux-kernel - Re: [RFC PATCH 1/2] aoe: add reference count in aoeif for tracking the using of net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e20707d4-53bc-400c-bb66-f1bd63e063e9@kernel.dk>
Date: Wed, 2 Oct 2024 12:38:30 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Chun-Yi Lee <joeyli.kernel@...il.com>, Justin Sanders <justin@...aid.com>
Cc: Pavel Emelianov <xemul@...nvz.org>, Kirill Korotaev <dev@...nvz.org>,
 "David S . Miller" <davem@...emloft.net>, Nicolai Stange <nstange@...e.com>,
 Greg KH <gregkh@...uxfoundation.org>, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, Chun-Yi Lee <jlee@...e.com>
Subject: Re: [RFC PATCH 1/2] aoe: add reference count in aoeif for tracking
 the using of net_device

On 10/1/24 10:06 PM, Chun-Yi Lee wrote:
> This is a patch for debugging. For tracking the reference count of using
> net_device in aoeif, this patch adds a nd_pcpu_refcnt field in aoeif
> structure. Two wrappers, nd_dev_hold() and nd_dev_put() are used to
> call dev_hold(nd)/dev_put(nd) and maintain ifp->nd_pcpu_refcnt at the
> same time.

There's no parallel universe in which using a percpu reference over just
a refcount_t for something like aoe is warranted.

-- 
Jens Axboe