linux-kernel - Re: [PATCH v1] mm: swap: Call count_mthp_stat() outside ifdef CONFIG_TRANSPARENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJD7tkYLD9815CLS+6FCkokeOvPt4Pa6XTnpUAGdaDJF9kdNmA@mail.gmail.com>
Date: Wed, 2 Oct 2024 12:01:51 -0700
From: Yosry Ahmed <yosryahmed@...gle.com>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org, 
	nphamcs@...il.com, chengming.zhou@...ux.dev, ryan.roberts@....com, 
	ying.huang@...el.com, 21cnbao@...il.com, akpm@...ux-foundation.org, 
	wajdi.k.feghali@...el.com, vinodh.gopal@...el.com
Subject: Re: [PATCH v1] mm: swap: Call count_mthp_stat() outside ifdef CONFIG_TRANSPARENT_HUGEPAGE.

On Wed, Oct 2, 2024 at 10:30 AM Kanchana P Sridhar
<kanchana.p.sridhar@...el.com> wrote:
>
> This patch moves the call to count_mthp_stat() in count_swpout_vm_event()
> to be outside the "ifdef CONFIG_TRANSPARENT_HUGEPAGE" based on changes
> made in commit 246d3aa3e53151fa150f10257ddd8a4facd31a6a ("mm: cleanup
>  count_mthp_stat() definition").
>
> Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>


I don't think this really makes a difference, but I will leave it to
the THP folks to decide.

However, if you go through with this, please also do the same for the
call in shrink_folio_list() for consistency.

>
> ---
>  mm/page_io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_io.c b/mm/page_io.c
> index 4aa34862676f..a28d28b6b3ce 100644
> --- a/mm/page_io.c
> +++ b/mm/page_io.c
> @@ -289,8 +289,8 @@ static inline void count_swpout_vm_event(struct folio *folio)
>                 count_memcg_folio_events(folio, THP_SWPOUT, 1);
>                 count_vm_event(THP_SWPOUT);
>         }
> -       count_mthp_stat(folio_order(folio), MTHP_STAT_SWPOUT);
>  #endif
> +       count_mthp_stat(folio_order(folio), MTHP_STAT_SWPOUT);
>         count_memcg_folio_events(folio, PSWPOUT, folio_nr_pages(folio));
>         count_vm_events(PSWPOUT, folio_nr_pages(folio));
>  }
> --
> 2.27.0
>