linux-kernel - Re: [PATCH] Revert "list: test: fix tests for list_cut

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b46f75a-cfef-4426-bab7-68959d044978@linuxfoundation.org>
Date: Wed, 2 Oct 2024 14:39:39 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Jacob Keller <jacob.e.keller@...el.com>,
 Guenter Roeck <linux@...ck-us.net>, David Gow <davidgow@...gle.com>
Cc: akpm@...ux-foundation.org, davidgow@...gle.com,
 kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, richard120310@...il.com,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] Revert "list: test: fix tests for list_cut_position()"

On 9/30/24 17:18, Jacob Keller wrote:
> 
> 
> On 9/22/2024 8:05 AM, Guenter Roeck wrote:
>> This reverts commit e620799c414a035dea1208bcb51c869744931dbb.
>>
>> The commit introduces unit test failures.
>>
>>       Expected cur == &entries[i], but
>>           cur == 0000037fffadfd80
>>           &entries[i] == 0000037fffadfd60
>>       # list_test_list_cut_position: pass:0 fail:1 skip:0 total:1
>>       not ok 21 list_test_list_cut_position
>>       # list_test_list_cut_before: EXPECTATION FAILED at lib/list-test.c:444
>>       Expected cur == &entries[i], but
>>           cur == 0000037fffa9fd70
>>           &entries[i] == 0000037fffa9fd60
>>       # list_test_list_cut_before: EXPECTATION FAILED at lib/list-test.c:444
>>       Expected cur == &entries[i], but
>>           cur == 0000037fffa9fd80
>>           &entries[i] == 0000037fffa9fd70
>>
>> Revert it.
>>
>> Fixes: e620799c414a ("list: test: fix tests for list_cut_position()")
>> Cc: I Hsin Cheng <richard120310@...il.com>
>> Cc: David Gow <davidgow@...gle.com>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>> ---
> 
> I ran into this as well.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> 

Please take a look and let me know if you are okay with this patch.

thanks,
-- Shuah