linux-kernel - Re: [PATCH 0/3] drivers: nubus: Fix coding style issues in nubus.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a403ccb-1d77-4c90-8e7d-35cbafdf5633@linuxfoundation.org>
Date: Wed, 2 Oct 2024 16:20:12 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Sayyad Abid <sayyad.abid16@...il.com>, linux-m68k@...ts.linux-m68k.org
Cc: fthain@...ux-m68k.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 0/3] drivers: nubus: Fix coding style issues in nubus.c

On 10/2/24 07:28, Sayyad Abid wrote:
> This patch series addresses coding style improvements in
> the Nubus subsystem, specifically in `nubus.c`. These changes
> aim to enhance readability and maintainability of the code.
> 
> These coding style inconsistencies were found using checkpatch.pl
> 
> Changes include:
>   1. Improved comment block formatting by aligning `*` in
>      multi-line comments.
>   2. Fixing assignments inside conditional statements to improve clarity.
>   3. Correcting the use of tabs for indentation in specific functions.
> 
> Each commit focuses on a specific aspect, as detailed below.
> 
> 
> Sayyad Abid (3):
>    Fix use of tabs in nubus_get_vendorinfo and nubus_add_board
>    Fix use of assignment in if condition in nubus_add_board()
>    Fix use of * in comment block in nubus.c
> 
>   drivers/nubus/nubus.c | 94 ++++++++++++++++++++++++-------------------
>   1 file changed, 53 insertions(+), 41 deletions(-)
> 
> --
> 2.39.5
> 

Why are you sending 3 patches for these changes in one single
file?

thanks,
-- Shuah