linux-kernel - Re: [PATCH v1 01/11] dt-bindings: mailbox: mpfs: fix reg properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172791083082.1519634.10076484205246276978.robh@kernel.org>
Date: Wed, 2 Oct 2024 18:13:51 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
	Palmer Dabbelt <palmer@...belt.com>,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Kevin Hilman <khilman@...libre.com>,
	Jerome Brunet <jbrunet@...libre.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Daire McNamara <daire.mcnamara@...rochip.com>,
	Michael Turquette <mturquette@...libre.com>,
	linux-kernel@...r.kernel.org, pierre-henry.moussay@...rochip.com,
	Stephen Boyd <sboyd@...nel.org>,
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
	Jassi Brar <jassisinghbrar@...il.com>,
	valentina.fernandezalanis@...rochip.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, Lee Jones <lee@...nel.org>,
	Conor Dooley <conor.dooley@...rochip.com>,
	linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
	linux-riscv@...ts.infradead.org, Albert Ou <aou@...s.berkeley.edu>,
	Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH v1 01/11] dt-bindings: mailbox: mpfs: fix reg properties


On Wed, 02 Oct 2024 11:47:59 +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> When the binding for this was originally written, and later modified,
> mistakes were made - and the precise nature of the later modification
> should have been a giveaway, but alas I was naive at the time.
> 
> A more correct modelling of the hardware is to use two syscons and have
> a single reg entry for the mailbox, containing the mailbox region. The
> two syscons contain the general control/status registers for the mailbox
> and the interrupt related registers respectively. The reason for two
> syscons is that the same mailbox is present on the non-SoC version of
> the FPGA, which has no interrupt controller, and the shared part of the
> rtl was unchanged between devices.
> 
> This is now coming to a head, because the control/status registers share
> a register region with the "tvs" (temperature & voltage sensors)
> registers and, as it turns out, people do want to monitor temperatures
> and voltages...
> 
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>  .../bindings/mailbox/microchip,mpfs-mailbox.yaml    | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@...nel.org>