[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <idkorrjd5g2yjcnclks55pozf6rrv2w4fyhbwaaznvq5ngmcdm@vxpjh6q4visi>
Date: Wed, 2 Oct 2024 08:04:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Macpaul Lin <macpaul.lin@...iatek.com>
Cc: Rob Herring <robh@...nel.org>, Chun-Kuang Hu <chunkuang.hu@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Yong Wu <yong.wu@...iatek.com>, Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
Robin Murphy <robin.murphy@....com>, Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Rohit Agarwal <rohiagar@...omium.org>,
dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, iommu@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
Alexandre Mergnat <amergnat@...libre.com>, Bear Wang <bear.wang@...iatek.com>,
Pablo Sun <pablo.sun@...iatek.com>, Macpaul Lin <macpaul@...il.com>, Sen Chu <sen.chu@...iatek.com>,
Chris-qj chen <chris-qj.chen@...iatek.com>,
MediaTek Chromebook Upstream <Project_Global_Chrome_Upstream_Group@...iatek.com>, Chen-Yu Tsai <wenst@...omium.org>,
Jitao Shi <jitao.shi@...iatek.com>
Subject: Re: [PATCH v4 5/5] dt-bindings: display: mediatek: dpi: correct
power-domains property
On Wed, Oct 02, 2024 at 11:09:07AM +0800, Macpaul Lin wrote:
>
>
> On 10/2/24 09:51, Rob Herring wrote:
> >
> >
> > External email : Please do not click links or open attachments until you
> > have verified the sender or the content.
> >
> > On Mon, Sep 30, 2024 at 04:38:54PM +0800, Macpaul Lin wrote:
> > > The MediaTek DPI module is typically associated with one of the
> > > following multimedia power domains:
> > > - POWER_DOMAIN_DISPLAY
> > > - POWER_DOMAIN_VDOSYS
> > > - POWER_DOMAIN_MM
> > > The specific power domain used varies depending on the SoC design.
> > >
> > > These power domains are shared by multiple devices within the SoC.
> > > In most cases, these power domains are enabled by other devices.
> > > As a result, the DPI module of legacy SoCs often functions correctly
> > > even without explicit configuration.
> > >
> > > It is recommended to explicitly add the appropriate power domain
> > > property to the DPI node in the device tree. Hence drop the
> > > compatible checking for specific SoCs.
> > >
> > > Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains")
> > > Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
> > > Signed-off-by: Jitao Shi <jitao.shi@...iatek.com>
> > > Signed-off-by: Pablo Sun <pablo.sun@...iatek.com>
> > > ---
> > > .../display/mediatek/mediatek,dpi.yaml | 24 ++++++++-----------
> > > 1 file changed, 10 insertions(+), 14 deletions(-)
> >
> > You missed Krzysztof's R-by tag.
> >
>
> Oh, I just missed that reply for v3 in the mailbox
> and thought it still need to be reviewed.
> I just found Krzysztof's R-by tag in the mailbox right now.
>
> I'll send an update for this patch set.
> Thanks for the reminder.
Plaese, instead just start using b4...
Best regards,
Krzysztof
Powered by blists - more mailing lists