linux-kernel - RE: [net-next v2 0/2] ena: Link IRQs, queues, and NAPI instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ca2ee862356426e84b840db94496581@amazon.com>
Date: Wed, 2 Oct 2024 06:28:48 +0000
From: "Arinzon, David" <darinzon@...zon.com>
To: Joe Damato <jdamato@...tly.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "Kiyanovski, Arthur" <akiyano@...zon.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Kamal Heib <kheib@...hat.com>, open list
	<linux-kernel@...r.kernel.org>, "Dagan, Noam" <ndagan@...zon.com>, "Paolo
 Abeni" <pabeni@...hat.com>, "Bshara, Saeed" <saeedb@...zon.com>, "Agroskin,
 Shay" <shayagr@...zon.com>
Subject: RE: [net-next v2 0/2] ena: Link IRQs, queues, and NAPI instances


> Greetings:
> 
> Welcome to v2. This includes only cosmetic changes, see changelog below
> and in each patch.
> 
> This series uses the netdev-genl API to link IRQs and queues to NAPI IDs so
> that this information is queryable by user apps. This is particularly useful for
> epoll-based busy polling apps which rely on having access to the NAPI ID.
> 
> I've tested these commits on an EC2 instance with an ENA NIC configured
> and have included test output in the commit messages for each patch
> showing how to query the information.
> 
> I noted in the implementation that the driver requests an IRQ for
> management purposes which does not have an associated NAPI. I tried to
> take this into account in patch 1, but would appreciate if ENA maintainers can
> verify I did this correctly.
> 
> Thanks,
> Joe
> 
> v2:
>   - Preserve reverse christmas tree ordering in patch 1
>   - Add comment that the API is for non-XDP queues only to patch 2
> 
> v1:
>   - https://lore.kernel.org/all/20240930195617.37369-1-jdamato@fastly.com/
> 
> Joe Damato (2):
>   ena: Link IRQs to NAPI instances
>   ena: Link queues to NAPIs
> 
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 40
> +++++++++++++++++---
>  1 file changed, 35 insertions(+), 5 deletions(-)
> 
> --
> 2.25.1

Thanks!

Reviewed-by: David Arinzon <darinzon@...zon.com>