linux-kernel - Re: [PATCH v3] aoe: fix the potential use-after-free problem in more places

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024100233-email-regalia-8b66@gregkh>
Date: Wed, 2 Oct 2024 08:50:43 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Chun-Yi Lee <joeyli.kernel@...il.com>
Cc: Justin Sanders <justin@...aid.com>, Jens Axboe <axboe@...nel.dk>,
	Pavel Emelianov <xemul@...nvz.org>,
	Kirill Korotaev <dev@...nvz.org>,
	"David S . Miller" <davem@...emloft.net>,
	Nicolai Stange <nstange@...e.com>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, Chun-Yi Lee <jlee@...e.com>
Subject: Re: [PATCH v3] aoe: fix the potential use-after-free problem in more
 places

On Wed, Oct 02, 2024 at 11:54:58AM +0800, Chun-Yi Lee wrote:
> For fixing CVE-2023-6270, f98364e92662 ("aoe: fix the potential
> use-after-free problem in aoecmd_cfg_pkts") makes tx() calling dev_put()
> instead of doing in aoecmd_cfg_pkts(). It avoids that the tx() runs
> into use-after-free.
> 
> Then Nicolai Stange found more places in aoe have potential use-after-free
> problem with tx(). e.g. revalidate(), aoecmd_ata_rw(), resend(), probe()
> and aoecmd_cfg_rsp(). Those functions also use aoenet_xmit() to push
> packet to tx queue. So they should also use dev_hold() to increase the
> refcnt of skb->dev.
> 
> On the other hand, moving dev_put() to tx() causes that the refcnt of
> skb->dev be reduced to a negative value, because corresponding
> dev_hold() are not called in revalidate(), aoecmd_ata_rw(), resend(),
> probe(), and aoecmd_cfg_rsp(). This patch fixed this issue.
> 
> Link: https://nvd.nist.gov/vuln/detail/CVE-2023-6270
> Fixes: f98364e92662 ("aoe: fix the potential use-after-free problem in aoecmd_cfg_pkts")
> Reported-by: Nicolai Stange <nstange@...e.com>
> Signed-off-by: Chun-Yi Lee <jlee@...e.com>
> ---
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot