linux-kernel - Re: [PATCH v10 3/6] mtd: spi-nor: core: Allow specifying the byte order in Octal DTR mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc4e9ddd-1a36-4496-89da-347c0eed23da@linaro.org>
Date: Wed, 2 Oct 2024 10:21:47 +0300
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: AlvinZhou <alvinzhou.tw@...il.com>, linux-mtd@...ts.infradead.org,
 linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
 pratyush@...nel.org, mwalle@...nel.org, miquel.raynal@...tlin.com,
 richard@....at, vigneshr@...com, broonie@...nel.org
Cc: chengminglin@...c.com.tw, leoyu@...c.com.tw,
 AlvinZhou <alvinzhou@...c.com.tw>, JaimeLiao <jaimeliao@...c.com.tw>
Subject: Re: [PATCH v10 3/6] mtd: spi-nor: core: Allow specifying the byte
 order in Octal DTR mode



On 26.09.2024 17:19, AlvinZhou wrote:
> +
> +	/* SWAP16 is only applicable when Octal DTR mode */

the comment is redundant, I can already see the condition in the if
below. No need to resend, I'll amend when applying. Looking good.

> +	if (proto == SNOR_PROTO_8_8_8_DTR && nor->flags & SNOR_F_SWAP16)
> +		op->data.swap16 = true;