linux-kernel - Re: [PATCH v8 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8d36c55e-1dee-4bda-a1f5-d2033e116a56@collabora.com>
Date: Wed, 2 Oct 2024 11:32:55 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Jianeng Ceng <cengjianeng@...qin.corp-partner.google.com>
Cc: linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
 hsinyi@...gle.com, dri-devel@...ts.freedesktop.org, conor+dt@...nel.org,
 matthias.bgg@...il.com, knoxchiou@...gle.com, devicetree@...r.kernel.org,
 krzk+dt@...nel.org, "Rob Herring (Arm)" <robh@...nel.org>
Subject: Re: [PATCH v8 0/2] arm64: dts: mediatek: Add MT8186 Ponyta

Il 16/09/24 19:19, Rob Herring (Arm) ha scritto:
> 
> On Sat, 14 Sep 2024 14:31:20 +0800, Jianeng Ceng wrote:
>> This is v8 of the MT8186 Chromebook device tree series.
>> ---
>> Changes in v8:
>> - PATCH 1/2: Remove custom label.
>> - PATCH 2/2: Change the commit about ponyta.
>> - Link to v7:https://lore.kernel.org/all/20240913031505.372868-1-cengjianeng@huaqin.corp-partner.google.com/
>>
>> Changes in v7:
>> - PATCH 2/2: Remove prototype sku.
>> - PATCH 2/2: Disable the other trackpad to enable one of them.
>> - Link to v5:https://lore.kernel.org/all/20240913015503.4192806-1-cengjianeng@huaqin.corp-partner.google.com/
>>
>> Changes in v6:
>> - No change.
>>
>> Changes in v5:
>> - PATCH 1/2: Remove sku2147483647.
>> - PATCH 2/2: Remove sku2147483647.
>> - Link to v4:https://lore.kernel.org/all/20240906085739.1322676-1-cengjianeng@huaqin.corp-partner.google.com/
>>
>> Changes in v4:
>> - PATCH 1/2: Add more info for Ponyta custom label in commit.
>> - Link to v3:https://lore.kernel.org/all/20240904081501.2060933-1-cengjianeng@huaqin.corp-partner.google.com/
>>
>> Changes in v3:
>> - PATCH 0/2: Add the modify records.
>> - PATCH 1/2: Modify lable to label.
>> - Link to v2:https://lore.kernel.org/all/20240903061603.3007289-1-cengjianeng@huaqin.corp-partner.google.com/
>>
>> Changes in v2:
>> - PATCH 2/2: Modify the dtb name without rev2.
>> - Link to v1:https://lore.kernel.org/all/20240902125502.1844374-1-cengjianeng@huaqin.corp-partner.google.com/
>>
>> Jianeng Ceng (2):
>>    dt-bindings: arm: mediatek: Add MT8186 Ponyta Chromebook
>>    arm64: dts: mediatek: Add MT8186 Ponyta Chromebooks
>>
>>   .../devicetree/bindings/arm/mediatek.yaml     | 10 +++++
>>   arch/arm64/boot/dts/mediatek/Makefile         |  2 +
>>   .../mediatek/mt8186-corsola-ponyta-sku0.dts   | 18 ++++++++
>>   .../mediatek/mt8186-corsola-ponyta-sku1.dts   | 22 ++++++++++
>>   .../dts/mediatek/mt8186-corsola-ponyta.dtsi   | 44 +++++++++++++++++++
>>   5 files changed, 96 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dts
>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dts
>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta.dtsi
>>
>> --
>> 2.34.1
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>    pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y mediatek/mt8186-corsola-ponyta-sku0.dtb mediatek/mt8186-corsola-ponyta-sku1.dtb' for 20240914063122.1622196-1-cengjianeng@...qin.corp-partner.google.com:
> 
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@...0d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@...0d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@...0d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@...0d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@...0d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@...0d000/pmic: failed to match any schema with compatible: ['mediatek,mt6366', 'mediatek,mt6358']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@...0d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@...0d000/pmic/codec: failed to match any schema with compatible: ['mediatek,mt6366-sound', 'mediatek,mt6358-sound']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@...0d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: /soc/pwrap@...0d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@...0d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: /soc/pwrap@...0d000/pmic/rtc: failed to match any schema with compatible: ['mediatek,mt6366-rtc', 'mediatek,mt6358-rtc']

Hello Jianeng,
I can't apply this series unless you fix the following warnings from the DTB check:

> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: dp-bridge@5c: 'extcon' is a required property
> 	from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml#
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: dp-bridge@5c: 'extcon' is a required property
> 	from schema $id: http://devicetree.org/schemas/display/bridge/ite,it6505.yaml#
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku0.dtb: sound: 'model' is a required property
> 	from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#
> arch/arm64/boot/dts/mediatek/mt8186-corsola-ponyta-sku1.dtb: sound: 'model' is a required property
> 	from schema $id: http://devicetree.org/schemas/sound/mt8186-mt6366-rt1019-rt5682s.yaml#
> 

Regards,
Angelo