linux-kernel - Re: [PATCH v1] iio: adc: pac1921: add ACPI support for pac1921

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b459b62eed7418d4eadb60b4f1e4816448176e20.camel@microchip.com>
Date: Wed, 2 Oct 2024 12:44:16 +0000
From: <Victor.Duicu@...rochip.com>
To: <jic23@...nel.org>
CC: <Marius.Cristea@...rochip.com>, <matteomartelli3@...il.com>,
	<lars@...afoo.de>, <linux-iio@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] iio: adc: pac1921: add ACPI support for pac1921

On Sat, 2024-09-28 at 17:42 +0100, Jonathan Cameron wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Wed, 25 Sep 2024 18:08:56 +0300
> <victor.duicu@...rochip.com> wrote:
> 
> > From: Victor Duicu <victor.duicu@...rochip.com>
> > 
> > 
> >  MODULE_DEVICE_TABLE(of, pac1921_of_match);
> > 
> > +static const struct acpi_device_id pac1921_acpi_match[] = {
> > +     { "MCHP1921" },
> 
> That's a valid ID for once which is good. I'll assume Microchip
> has a process for tracking these and avoiding clashes.
> 

MCHP id is registered with UEFI and MCHP1921 is tracked internally.

> > +     { }
> > +};
> > +MODULE_DEVICE_TABLE(acpi, pac1921_acpi_match);
> >  static struct i2c_driver pac1921_driver = {
> >       .driver  = {
> >               .name = "pac1921",
> >               .pm = pm_sleep_ptr(&pac1921_pm_ops),
> >               .of_match_table = pac1921_of_match,
> > +             .acpi_match_table = pac1921_acpi_match
> >       },
> >       .probe = pac1921_probe,
> >       .id_table = pac1921_id,
> > 
> > base-commit: fec496684388685647652ab4213454fbabdab099
>