[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241002125243.GC7504@google.com>
Date: Wed, 2 Oct 2024 13:52:43 +0100
From: Lee Jones <lee@...nel.org>
To: Werner Sembach <wse@...edocomputers.com>
Cc: bentiss@...nel.org, dri-devel@...ts.freedesktop.org,
hdegoede@...hat.com, jelle@...aa.nl, jikos@...nel.org,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org, miguel.ojeda.sandonis@...il.com,
ojeda@...nel.org, onitake@...il.com, pavel@....cz, cs@...edo.de
Subject: Re: [PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for
TUXEDO
On Fri, 27 Sep 2024, Werner Sembach wrote:
> Hi,
> first revision integrating Armins feedback.
>
> Stuff I did not yet change and did not comment on previously:
> - Still have to ask Christoffer why the mutex is required
> - Still using acpi_size instad of size_t in the util functions, because the value is put directly into a struct using acpi_size
> - Error messages for __wmi_method_acpi_object_out still in that method because they reference method internal variables
>
> Let me know if my reasoning is flawed
Use `git format-patch`'s --annotate and --compose next time please.
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists