linux-kernel - Re: [PATCH v3 2/2 RESEND] checkpatch: warn on empty rust doc comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <t5SyWXgKghM_fSdMQNH3tTuqZKJck9qMTeUJUWzCWphs_cc7cocnj1gO5cCh0pzzVTCQbEBRqOsYC0om9JIOatBKU3AcoEyFwySAK6B1_Cw=@proton.me>
Date: Wed, 02 Oct 2024 02:17:08 +0000
From: Patrick Miller <paddymills@...ton.me>
To: Hridesh MG <hridesh699@...il.com>
Cc: Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org, Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>, Dwaipayan Ray <dwaipayanray1@...il.com>, Lukas Bulwahn <lukas.bulwahn@...il.com>, Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, Alice Ryhl <aliceryhl@...gle.com>, linux-newbie@...r.kernel.org
Subject: Re: [PATCH v3 2/2 RESEND] checkpatch: warn on empty rust doc comments






On Monday, September 30th, 2024 at 6:34 AM, Hridesh MG <hridesh699@...il.com> wrote:

> 

> 

> On Mon, Sep 30, 2024 at 8:11 AM Patrick Miller paddymills@...ton.me wrote:
> 

> > After the latest revision of my patch 1, I split the if statement so that
> > there is a parent check for rust files for future rust patch checks. So,
> > this would perfectly fit within that block.
> > 

> > Do you want me to add your code and credit you in my patch?
> 

> 

> Please disregard my prior email, I had failed to CC everyone. Since
> the change is small I'm okay with adding it as part of your patch,
> please do add the Co-developed-by tag, thanks!
> 

> However, I was curious how conflicts like these are generally
> resolved. For example, if there are two large patchsets which conflict
> with each other, how does one ensure that they are compatible, and
> even if they are, how do the maintainers ensure that they are applied
> in the correct order?

2 changes that I am making to your patch as I merge it with mine (I tested these)
  - Added a @fix option. I ran into this with my patch and was requested to
      add it by a checkpatch maintainer
  - Revised your $prevrawline regex to check against existing blank lines as
      well as added blank lines (made the leading + optional). Otherwise I
      think the checkpatch would not match against a blank doc comment line
      added after an existing blank doc line.

Download attachment "signature.asc" of type "application/pgp-signature" (250 bytes)