linux-kernel - Re: [PATCH] printf: Remove unused 'bprintf'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zv1Uk_3W2hu1M8-9@smile.fi.intel.com>
Date: Wed, 2 Oct 2024 17:11:31 +0300
From: Andy Shevchenko <andy@...nel.org>
To: linux@...blig.org
Cc: kees@...nel.org, akpm@...ux-foundation.org, pmladek@...e.com,
	rostedt@...dmis.org, linux@...musvillemoes.dk,
	senozhatsky@...omium.org, linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printf: Remove unused 'bprintf'

On Wed, Oct 02, 2024 at 02:21:25AM +0100, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> bprintf is unused.  Remove it.

bprintf()

> It was added in
> commit 4370aa4aa753 ("vsprintf: add binary printf")
> 
> but as far as I can see was never used, unlike the other
> two functions in that patch.

Please, rewrap these lines to use more room on each line.

...

I am not familiar with tricks in BPF or ftrace code where this actually might
be implicitly called via a macro, but brief grep gives nothing that might point
to that. Hence, with the amended commit message

Reviewed-by: Andy Shevchenko <andy@...nel.org>

P.S. I hope we may rely in CIs to report issues soon, if any.

-- 
With Best Regards,
Andy Shevchenko