linux-kernel - Re: [PATCH v3 2/2] i2c: dwsignware: determine HS tHIGH and tLOW based on HW parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zv1WCAROWamTfI4z@smile.fi.intel.com>
Date: Wed, 2 Oct 2024 17:17:44 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Michael Wu <Michael.Wu@...ron.us>
Cc: Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	morgan chang <morgan.chang@...ron.us>,
	"mvp.kutali@...il.com" <mvp.kutali@...il.com>
Subject: Re: [PATCH v3 2/2] i2c: dwsignware: determine HS tHIGH and tLOW
 based on HW parameters

On Wed, Oct 02, 2024 at 09:31:00AM +0000, Michael Wu wrote:
> > On Tue, Oct 01, 2024 at 04:29:34PM +0800, Michael Wu wrote:

...

> > > + * @bus_capacitance_pf: bus capacitance in picofarads
> > 
> > Since it seems a new version of the series is warranted, and looking into
> > the current kernel source (no other users of this unit were observed),
> > I think we may do correct capitalisation here for the sake of physics
> > and unit system, i.e.
> > 
> >  * @bus_capacitance_pF: bus capacitance in picofarads
> 
> Are you serious?

Are we in the circus?

> I have never seen capital letters used to declare a
> variable name. Although checkpatch.pl does not consider this as an issue,
> is this against everyone's custom or unspoken rules?

I do not really care about checkpatch or any rules as any good rule will have
a few exceptions anyway. The rationale here is to follow the science with much
longer history than anything related to the computer programming.

Now, since you haven't looked for the existing examples, try this

	git grep -n _u[AV]\;

-- 
With Best Regards,
Andy Shevchenko