linux-kernel - Re: [PATCH v3 4/5] serial: 8250_exar: Remove old exar_ee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zv1Y2-KsGBQV1FX1@smile.fi.intel.com>
Date: Wed, 2 Oct 2024 17:29:47 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Parker Newman <parker@...est.io>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Parker Newman <pnewman@...necttech.com>
Subject: Re: [PATCH v3 4/5] serial: 8250_exar: Remove old exar_ee_read() and
 other unneeded code

On Wed, Oct 02, 2024 at 10:14:10AM -0400, Parker Newman wrote:
> From: Parker Newman <pnewman@...necttech.com>
> 
> Remove the old exar_ee_read() and associated helper functions.
> Remove defines that are no longer needed after the switch to using the
> eeprom_93cx6 driver.
> Add CTI_EE_MASK_OSC_FREQ define.

Seems like you have a rebase issues (you folded changes to the wrong patch).

...

>  drivers/tty/serial/8250/8250_exar.c | 95 +----------------------------
>  1 file changed, 2 insertions(+), 93 deletions(-)

Shouldn't be + lines here.

...

> +#define CTI_EE_MASK_OSC_FREQ		GENMASK(31, 0)

...

>  	osc_freq = le16_to_cpu(ee_words[0]) | (le16_to_cpu(ee_words[1]) << 16);
> -	if (osc_freq == GENMASK(31, 0))
> +	if (osc_freq == CTI_EE_MASK_OSC_FREQ)
>  		return -EIO;

You just introduced the - variant in the previous patch.
So, squash these two changes in the patch that adds this new conditional check.

-- 
With Best Regards,
Andy Shevchenko