linux-kernel - Re: [PATCH] printf: Remove unused 'bprintf'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zv1eJ-07dY2Drmh_@gallifrey>
Date: Wed, 2 Oct 2024 14:52:23 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Andy Shevchenko <andy@...nel.org>
Cc: kees@...nel.org, akpm@...ux-foundation.org, pmladek@...e.com,
	rostedt@...dmis.org, linux@...musvillemoes.dk,
	senozhatsky@...omium.org, linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] printf: Remove unused 'bprintf'

* Andy Shevchenko (andy@...nel.org) wrote:
> On Wed, Oct 02, 2024 at 02:31:19PM +0000, Dr. David Alan Gilbert wrote:
> > * Andy Shevchenko (andy@...nel.org) wrote:
> > > On Wed, Oct 02, 2024 at 02:21:25AM +0100, linux@...blig.org wrote:
> > > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > > > 
> > > > bprintf is unused.  Remove it.
> > > 
> > > bprintf()
> > 
> > OK.
> > 
> > > > It was added in
> > > > commit 4370aa4aa753 ("vsprintf: add binary printf")
> > > > 
> > > > but as far as I can see was never used, unlike the other
> > > > two functions in that patch.
> > > 
> > > Please, rewrap these lines to use more room on each line.
> > 
> > Something like this? :
> 
> > bprintf() is unused.  Remove it.  It was added in
> > 
> > commit 4370aa4aa753 ("vsprintf: add binary printf")
> > 
> > but as far as I can see was never used, unlike the other two functions in
> > that patch.
> 
> You have two blank lines in the middle, do you really need them?

No, I was just trying to keep the commit reference separate, I'm never
quite sure what checkpatch gets upset by.

> I would put it like this
> 
> bprintf() is unused. Remove it. It was added in the commit 4370aa4aa753
> ("vsprintf: add binary printf") but as far as I can see was never used,
> unlike the other two functions in that patch.

Sure, I can send a v2 like that.

Dave

> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/