linux-kernel - Re: [PATCH 2/4] dt-bindings: iio: adc: Add the GE HealthCare PMC ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241002-doorstop-given-0987c28090ed@spud>
Date: Wed, 2 Oct 2024 15:53:51 +0100
From: Conor Dooley <conor@...nel.org>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Ian Ray <ian.ray@...ealthcare.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 2/4] dt-bindings: iio: adc: Add the GE HealthCare PMC ADC

On Wed, Oct 02, 2024 at 09:04:53AM +0200, Herve Codina wrote:
> Hi Conor,
> 
> On Tue, 1 Oct 2024 18:03:37 +0100
> Conor Dooley <conor@...nel.org> wrote:
> 
> > On Tue, Oct 01, 2024 at 06:46:02PM +0200, Herve Codina wrote:
> > > On Tue, 1 Oct 2024 17:18:30 +0100
> > > Conor Dooley <conor@...nel.org> wrote:
> > >   
> > > > On Tue, Oct 01, 2024 at 09:46:16AM +0200, Herve Codina wrote:  
> > > > > The GE HealthCare PMC Analog to Digital Converter (ADC) is a 16-Channel
> > > > > (voltage and current), 16-Bit ADC with an I2C Interface.
> > > > > 
> > > > > Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> > > > > ---
> > > > >  .../bindings/iio/adc/gehc,pmc-adc.yaml        | 82 +++++++++++++++++++
> > > > >  include/dt-bindings/iio/adc/gehc,pmc-adc.h    | 10 +++  
> > > ...  
> > > > > +  clocks:
> > > > > +    maxItems: 1
> > > > > +
> > > > > +  clock-names:
> > > > > +    items:
> > > > > +      - const: osc    
> > > > 
> > > > Since there's no datasheet for me to look up, why is the clock optional?  
> > > 
> > > The component uses an external oscillator (osc) if an external oscillator is
> > > connected to its clock pins. Otherwise, it uses an internal reference clock.  
> > 
> > Could you please add a description of the clock with this statement,
> > given there's no datasheet or w/e linked here?
> 
> Sure, I will add a description in the next iteration.
> 
> There is no datasheet or any similar document available for this component.
> This is reason why I cannot add a link to this kind of dos.

Yeah, I had taken a look last night and couldn't find one, so I figured
that this was the case.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)