linux-kernel - [PATCH 0/2] drm: Fix up and error handling after fbdev changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241002-vc4_fbdev_fix-v1-0-8737bd11b147@raspberrypi.com>
Date: Wed, 02 Oct 2024 16:06:18 +0100
From: Dave Stevenson <dave.stevenson@...pberrypi.com>
To: Maxime Ripard <mripard@...nel.org>, 
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
 Simona Vetter <simona@...ll.ch>, 
 Javier Martinez Canillas <javierm@...hat.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
 Dave Stevenson <dave.stevenson@...pberrypi.com>
Subject: [PATCH 0/2] drm: Fix up and error handling after fbdev changes

I was trying dri-misc-next on Pi4 and getting a NULL deref as vc4
started. The cause was having missed adding DRM_FBDEV_DMA_DRIVER_OPS
to the 2711 struct drm_driver, but also showed up that the handling
in drm_fb_helper_single_fb_probe could fail to call any fbdev_probe
function, and hence the NULL deref.

These two patches fix up vc4, but also throw an error if neither
driver->fbdev_probe nor funcs->fb_probe are defined.

Signed-off-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
---
Dave Stevenson (2):
      drm/vc4: Run default client setup for all variants.
      drm/fbdev: Ensure that one of the probe functions is defined

 drivers/gpu/drm/drm_fb_helper.c | 2 ++
 drivers/gpu/drm/vc4/vc4_drv.c   | 1 +
 2 files changed, 3 insertions(+)
---
base-commit: 86fdd6b9b1e98cfd26249505e8ce72f4fc0de37f
change-id: 20241002-vc4_fbdev_fix-f4c8b11928cd

Best regards,
-- 
Dave Stevenson <dave.stevenson@...pberrypi.com>