linux-kernel - [PATCH] drm: rcar-du: Reduce of_node_put(cmm) calls in rcar_du_cmm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <504bb76d-d8ee-4332-ab3d-ad6b2482c29c@web.de>
Date: Thu, 3 Oct 2024 20:05:27 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: dri-devel@...ts.freedesktop.org, linux-renesas-soc@...r.kernel.org,
 David Airlie <airlied@...il.com>, Jacopo Mondi <jacopo+renesas@...ndi.org>,
 Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Simona Vetter <simona@...ll.ch>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: [PATCH] drm: rcar-du: Reduce of_node_put(cmm) calls in
 rcar_du_cmm_init()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Thu, 3 Oct 2024 19:56:29 +0200

An of_node_put(cmm) call was immediately used after a null pointer check
for an of_find_device_by_node() call in this function implementation.
Thus call such a function instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
index 70d8ad065bfa..a854b2b085f9 100644
--- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
@@ -792,14 +792,12 @@ static int rcar_du_cmm_init(struct rcar_du_device *rcdu)
 		}

 		pdev = of_find_device_by_node(cmm);
+		of_node_put(cmm);
 		if (!pdev) {
 			dev_err(rcdu->dev, "No device found for CMM%u\n", i);
-			of_node_put(cmm);
 			return -EINVAL;
 		}

-		of_node_put(cmm);
-
 		/*
 		 * -ENODEV is used to report that the CMM config option is
 		 * disabled: return 0 and let the DU continue probing.
--
2.46.1