linux-kernel - Re: [PATCH 18/23] kbuild: remove extmod_prefix, MODORDER, MODULES

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241003-petite-mamba-of-champagne-d9e0ac@lindesnes>
Date: Thu, 3 Oct 2024 20:47:06 +0200
From: Nicolas Schier <nicolas@...sle.eu>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: linux-kbuild@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH 18/23] kbuild: remove extmod_prefix, MODORDER,
 MODULES_NSDEPS variables

On Tue, Sep 17, 2024 at 11:16:46PM +0900, Masahiro Yamada wrote:
> With the previous changes, $(extmod_prefix), $(MODORDER), and
> $(MODULES_NSDEPS) are constant. (empty, modules.order, and
> modules.nsdeps, respectively).
> 
> Remove these variables and hard-code their values.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  Makefile                  | 22 +++++++++-------------
>  scripts/Makefile.modfinal |  2 +-
>  scripts/Makefile.modinst  |  2 +-
>  scripts/Makefile.modpost  |  6 +++---
>  scripts/nsdeps            |  2 +-
>  5 files changed, 15 insertions(+), 19 deletions(-)

Do you want to remove these also?  I can't think of a reason to keep these
around:

$ git grep -Hrnwe extmod_prefix -e MODORDER -e MODULES_NSDEP
Makefile:1912:  $(Q){ $(foreach m, $(single-ko), echo $(extmod_prefix)$(m:%.ko=%.o);) } > modules.order
scripts/Makefile.modfinal:33:$(extmod_prefix).module-common.o: $(srctree)/scripts/module-common.c FORCE
scripts/Makefile.modfinal:60:%.ko: %.o %.mod.o $(extmod_prefix).module-common.o $(objtree)/scripts/module.lds $(and $(CONFIG_DEBUG_INFO_BTF_MODULES),$(KBUILD_BUILTIN),$(objtree)/vmlinux) FORCE
scripts/Makefile.modfinal:66:targets += $(modules:%.o=%.ko) $(modules:%.o=%.mod.o) $(extmod_prefix).module-common.o
scripts/Makefile.modinst:60:modules := $(patsubst $(extmod_prefix)%.o, $(dst)/%.ko$(suffix-y), $(modules))
scripts/Makefile.modinst:120:$(dst)/%.ko: $(extmod_prefix)%.ko FORCE

W/ or w/o:

Reviewed-by: Nicolas Schier <nicolas@...sle.eu>