[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <57921df3-6b02-583f-c863-f227ca8103d5@amd.com>
Date: Thu, 3 Oct 2024 12:19:34 -0700
From: Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
To: Fan Ni <nifan.cxl@...il.com>
Cc: linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-cxl@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
Alison Schofield <alison.schofield@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>, Ira Weiny <ira.weiny@...el.com>,
Dan Williams <dan.j.williams@...el.com>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Yazen Ghannam <yazen.ghannam@....com>, Bowman Terry <terry.bowman@....com>
Subject: Re: [PATCH v2 3/4] acpi/ghes, efi/cper: Recognize and process CXL
Protocol Errors.
On 10/1/2024 10:41 AM, Fan Ni wrote:
> On Tue, Oct 01, 2024 at 12:52:33AM +0000, Smita Koralahalli wrote:
>> UEFI v2.10 section N.2.13 defines a CPER record for CXL Protocol errors.
>>
>> Add GHES support to detect CXL CPER Protocol Error Record and Cache Error
>> Severity, Device ID, Device Serial number and CXL RAS capability struct in
>> struct cxl_cper_prot_err. Include this struct as a member of struct
>> cxl_cper_work_data.
>>
>> Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>
>> ---
>> v2:
>> Defined array of structures for Device ID and Serial number
>> comparison.
>> p_err -> rec/p_rec.
>> ---
>> drivers/acpi/apei/ghes.c | 10 +++
>> drivers/firmware/efi/cper_cxl.c | 115 ++++++++++++++++++++++++++++++++
>> include/cxl/event.h | 26 ++++++++
>> 3 files changed, 151 insertions(+)
>>
>> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
>> index ada93cfde9ba..9dcf0f78458f 100644
>> --- a/drivers/acpi/apei/ghes.c
>> +++ b/drivers/acpi/apei/ghes.c
>> @@ -717,6 +717,14 @@ static void cxl_cper_post_event(enum cxl_event_type event_type,
>> schedule_work(cxl_cper_work);
>> }
>>
>> +static void cxl_cper_handle_prot_err(struct acpi_hest_generic_data *gdata)
>> +{
>> + struct cxl_cper_work_data wd;
>> +
>> + if (cxl_cper_handle_prot_err_info(gdata, &wd.p_rec))
>> + return;
>> +}
>
> Why we need a if here? It seems the function will return anyway.
>
> Fan
Yeah, it doesn't make sense here without 4/4.
Thanks
Smita
[snip]
Powered by blists - more mailing lists