linux-kernel - Re: [PATCH-next v2] Fix unintentional integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_OgZvTgUDvDqDikoUh28jTRm2mOAVV6zAEtWE9RHTFkyA@mail.gmail.com>
Date: Thu, 3 Oct 2024 17:22:35 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: "Sundararaju, Sathishkumar" <sasundar@....com>
Cc: Advait Dhamorikar <advaitdhamorikar@...il.com>, alexander.deucher@....com, 
	christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com, 
	simona@...ll.ch, leo.liu@....com, sathishkumar.sundararaju@....com, 
	saleemkhan.jamadar@....com, Veerabadhran.Gopalakrishnan@....com, 
	sonny.jiang@....com, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	skhan@...uxfoundation.org, anupnewsmail@...il.com
Subject: Re: [PATCH-next v2] Fix unintentional integer overflow

Applied.  Thanks!

On Thu, Oct 3, 2024 at 6:53 AM Sundararaju, Sathishkumar
<sasundar@....com> wrote:
>
>
> The patch is Reviewed-by: Sathishkumar S <sathishkumar.sundararaju@....com>
>
> Regards,
> Sathish
>
>
> On 10/3/2024 3:56 PM, Advait Dhamorikar wrote:
> > Fix shift-count-overflow in JPEG instance
> > multiplication. The expression's value may not be
> > what the programmer intended, because the expression
> > is evaluated using a narrower integer type.
> >
> > Fixes: f0b19b84d391 ("drm/amdgpu: add amdgpu_jpeg_sched_mask debugfs")
> > Signed-off-by: Advait Dhamorikar <advaitdhamorikar@...il.com>
> > ---
> >   V1 -> V2: addressed review comments
> >
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c
> > index 95e2796919fc..b6f0435f56ba 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c
> > @@ -357,7 +357,7 @@ static int amdgpu_debugfs_jpeg_sched_mask_set(void *data, u64 val)
> >       if (!adev)
> >               return -ENODEV;
> >
> > -     mask = (1 << (adev->jpeg.num_jpeg_inst * adev->jpeg.num_jpeg_rings)) - 1;
> > +     mask = ((uint64_t)1 << (adev->jpeg.num_jpeg_inst * adev->jpeg.num_jpeg_rings)) - 1;
> >       if ((val & mask) == 0)
> >               return -EINVAL;
> >