linux-kernel - Re: [PATCH v3] lib/math: Add int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bb534e04-618d-48b9-ae19-00301e7c73b4@linuxfoundation.org>
Date: Thu, 3 Oct 2024 15:39:10 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: David Gow <davidgow@...gle.com>,
 Bruno Sobreira França <brunofrancadevsec@...il.com>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
 rmoar@...gle.com, kunit-dev@...glegroups.com,
 linux-kernel-mentees@...ts.linuxfoundation.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] lib/math: Add int_log test suite

On 10/3/24 01:00, David Gow wrote:
> On Wed, 25 Sept 2024 at 10:56, Bruno Sobreira França
> <brunofrancadevsec@...il.com> wrote:
>>
>> This commit introduces KUnit tests for the intlog2 and intlog10
>> functions, which compute logarithms in base 2 and base 10, respectively.
>> The tests cover a range of inputs to ensure the correctness of these
>> functions across common and edge cases.
>>
>> Signed-off-by: Bruno Sobreira França <brunofrancadevsec@...il.com>
>> ---
> 
> Thanks, this looks good to me.
> 
> Reviewed-by: David Gow <davidgow@...gle.com>
> 
> Cheers,
> -- David
> 
>> Changes in v3:
>>    - Fix checkpatch issues reintroduced in v2
>> Changes in v2:
>>    - Fix the overflow warning reported by the kernel test robot
>> ---

Bruno,

This doesn't apply - please rebase on top of linux-kselftest kunit branch
and send me v4.

I tried to apply, but a few too many merge conflicts. Rebase is a safer
option.

thanks,
-- Shuah