[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241003221006.4568-2-ansuelsmth@gmail.com>
Date: Fri, 4 Oct 2024 00:10:05 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Florian Fainelli <f.fainelli@...il.com>,
Christian Marangi <ansuelsmth@...il.com>,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Daniel Golle <daniel@...rotopia.org>,
stable@...r.kernel.org
Subject: [net PATCH 2/2] net: phy: Skip PHY LEDs OF registration for Generic PHY driver
It might happen that a PHY driver fails to probe or is not present in
the system as it's a kmod. In such case the Device Tree might have LED
entry but the Generic PHY is probed instead.
In this scenario, PHY LEDs OF registration should be skipped as
controlling the PHY LEDs is not possible.
Tested-by: Daniel Golle <daniel@...rotopia.org>
Cc: stable@...r.kernel.org
Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs")
Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
---
drivers/net/phy/phy_device.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 499797646580..af088bf00bae 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -3411,6 +3411,11 @@ static int of_phy_leds(struct phy_device *phydev)
struct device_node *leds;
int err;
+ /* Skip LED registration if we are Generic PHY */
+ if (phy_driver_is_genphy(phydev) ||
+ phy_driver_is_genphy_10g(phydev))
+ return 0;
+
if (!IS_ENABLED(CONFIG_OF_MDIO))
return 0;
--
2.45.2
Powered by blists - more mailing lists