linux-kernel - Re: [PATCH] fix typo in Documentation/wmi/devices/dell-wmi-ddv.rst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17bc2698-9113-4cf0-b58b-4f9db1813753@gmx.de>
Date: Fri, 4 Oct 2024 01:03:29 +0200
From: Armin Wolf <W_Armin@....de>
To: Anaswara T Rajan <anaswaratrajan@...il.com>
Cc: corbet@....net, platform-driver-x86@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix typo in Documentation/wmi/devices/dell-wmi-ddv.rst

Am 02.10.24 um 12:07 schrieb Anaswara T Rajan:

> typo in word 'diagnostics'

Please rename your patch to "platform/x86: dell-ddv: Fix typo in documentation" and
rework the patch description so it forms a full sentence.

Other than that, the patch look fine.

Thanks,
Armin Wolf

> Signed-off-by: Anaswara T Rajan <anaswaratrajan@...il.com>
> ---
>   Documentation/wmi/devices/dell-wmi-ddv.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/wmi/devices/dell-wmi-ddv.rst b/Documentation/wmi/devices/dell-wmi-ddv.rst
> index 2fcdfcf03327..e0c20af30948 100644
> --- a/Documentation/wmi/devices/dell-wmi-ddv.rst
> +++ b/Documentation/wmi/devices/dell-wmi-ddv.rst
> @@ -8,7 +8,7 @@ Introduction
>   ============
>
>   Many Dell notebooks made after ~2020 support a WMI-based interface for
> -retrieving various system data like battery temperature, ePPID, diagostic data
> +retrieving various system data like battery temperature, ePPID, diagnostic data
>   and fan/thermal sensor data.
>
>   This interface is likely used by the `Dell Data Vault` software on Windows,
> @@ -277,7 +277,7 @@ Reverse-Engineering the DDV WMI interface
>   4. Try to deduce the meaning of a certain WMI method by comparing the control
>      flow with other ACPI methods (_BIX or _BIF for battery related methods
>      for example).
> -5. Use the built-in UEFI diagostics to view sensor types/values for fan/thermal
> +5. Use the built-in UEFI diagnostics to view sensor types/values for fan/thermal
>      related methods (sometimes overwriting static ACPI data fields can be used
>      to test different sensor type values, since on some machines this data is
>      not reinitialized upon a warm reset).