linux-kernel - Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7b4c6601d648e0eba2dc66f0fe1f34ca3d29cfb.camel@mediatek.com>
Date: Thu, 3 Oct 2024 05:17:46 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: Bibby Hsieh (謝濟遠) <Bibby.Hsieh@...iatek.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>, "djkurtz@...omium.org"
	<djkurtz@...omium.org>, Shawn Sung (宋孝謙)
	<Shawn.Sung@...iatek.com>, Nancy Lin (林欣螢)
	<Nancy.Lin@...iatek.com>, "daniel@...ll.ch" <daniel@...ll.ch>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	CK Hu (胡俊光) <ck.hu@...iatek.com>,
	"airlied@...il.com" <airlied@...il.com>, "me@...mthiede.com"
	<me@...mthiede.com>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"littlecvr@...omium.org" <littlecvr@...omium.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: YT Shen (沈岳霆) <Yt.Shen@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 13/14] drm/mediatek: Support DRM plane alpha in OVL

> Jason:
> That is a lot of information, and quite above my head! Thank you
> though.
> 
> I should note that the log items I sent you are from the "good"
> kernel - 
> 6.11 with the commit reverted. Here is a much longer set of logs: 
> https://termbin.com/co6v
> 
> I've rebuild 6.11 with the log statement enabled and the "bad"
> behavior.
> Here is a dmesg from that: https://termbin.com/xiev
> 
Hi Adam,

I think something wrong with your dmesg links, both logs look the same.
We should see this log in the "bad" one:
fmt:0x34325258, has_alpha:0x0, alpha:0xffff, con:0x2000

But anyway, I think the reason for the downgrade is clear enough to me.
So let's try to figure out the solution.

> These logs are both from `dmesg`.
> 
> I'm fairly certain I've built with the patch you referenced enabled.
> The 
> kernels I run are just release kernels, not RCs or git branches or 
> anything. The mainline v6.11 kernel is the one that has this problem.
> If 
> that patch has been merged into 6.11 (which, looks like it has) then 
> it's in the kernel I'm building.

Got it.
Then OVL_CONST_BLEND might be the unsupported configuration in MT8173,
I think we should remove the XRGB8888 format for MT8173.

Could you please try this modification and see if it'll change to use
others supported format to show the text?

--- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
@@ -102,12 +102,9 @@ static inline bool is_10bit_rgb(u32 fmt)
 }

 static const u32 mt8173_formats[] = {
-       DRM_FORMAT_XRGB8888,
        DRM_FORMAT_ARGB8888,
-       DRM_FORMAT_BGRX8888,
        DRM_FORMAT_BGRA8888,
        DRM_FORMAT_ABGR8888,
-       DRM_FORMAT_XBGR8888,
        DRM_FORMAT_RGB888,
        DRM_FORMAT_BGR888,
        DRM_FORMAT_RGB565,


Regards,
Jason-JH.Lin

> 
> - Adam Thiede