[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <tqsrnsvciupbovlalqsnrp5whst2mrpqntjblvymcunpesvake@o3gxa7vik7he>
Date: Thu, 3 Oct 2024 08:28:12 +0200
From: Markus Schneider-Pargmann <msp@...libre.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>, Pavel Machek <pavel@....cz>,
Len Brown <len.brown@...el.com>, Vishal Mahaveer <vishalm@...com>,
Kevin Hilman <khilman@...libre.com>, Dhruva Gole <d-gole@...com>, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PM: QoS: Export dev_pm_qos_read_value
On Thu, Oct 03, 2024 at 08:02:04AM GMT, Greg Kroah-Hartman wrote:
> On Wed, Oct 02, 2024 at 09:44:46PM +0200, Markus Schneider-Pargmann wrote:
> > Export the function dev_pm_qos_read_value(). Most other functions
> > mentioned in Documentation/power/pm_qos_interface.rst are already
> > exported, so export this one as well.
> >
> > This function will be used to read the resume latency in a driver that
> > can also be compiled as a module.
>
> We don't add exports for no in-kernel users, sorry. Send this as part
> of a series that requires it.
Sorry if this was unclear, it is for an in-kernel driver (ti_sci.c) that
can be built as a module. When built as a module it can't use this
function if it is not exported.
>
> > Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> > Reviewed-by: Dhruva Gole <d-gole@...com>
> > Reviewed-by: Kevin Hilman <khilman@...libre.com>
> > Tested-by: Kevin Hilman <khilman@...libre.com>
> > ---
> >
> > Notes:
> > Changes in v2:
> > - Rephrase the commit message
> > - Move the patch out of the series
> > 'firmware: ti_sci: Introduce system suspend support'
>
> Odd, why did you do that?
It was suggested to me off-list that it may be better or easier to send
this separately.
Best
Markus
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists