linux-kernel - Re: [PATCH] powermac: Call of_node_put(bk_node) only once in pmac_has_backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e113d6b-c919-4b72-bd31-b8ab11e6a6f1@linaro.org>
Date: Thu, 3 Oct 2024 08:53:31 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Christophe Leroy <christophe.leroy@...roup.eu>
Cc: Markus Elfring <Markus.Elfring@....de>, linuxppc-dev@...ts.ozlabs.org,
 Jani Nikula <jani.nikula@...el.com>,
 Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Naveen N Rao <naveen@...nel.org>,
 Nicholas Piggin <npiggin@...il.com>, Paul Mackerras <paulus@...ba.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>,
 Thomas Zimmermann <tzimmermann@...e.de>, LKML
 <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] powermac: Call of_node_put(bk_node) only once in
 pmac_has_backlight_type()

On 03/10/2024 07:56, Dan Carpenter wrote:
> First of all, the change is wrong.  We can't dereference "prop" after calling
> of_node_put().  You have to be a bit extra careful reviewing Markus's patches
> because a lot of the rest of us have blocked these messages so you're on your
> own in that way.

Yep, I plonked him some time ago and everything is in spam.

The code looks just incorrect and I think Markus did not understand it
before transforming.

Best regards,
Krzysztof