linux-kernel - Re: [PATCH] scsi: wd33c93: Don't use stale scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18314bc8-bf29-c1de-d32c-dbc93ded975b@gmail.com>
Date: Thu, 3 Oct 2024 20:07:39 +1300
From: Michael Schmitz <schmitzmic@...il.com>
To: Finn Thain <fthain@...ux-m68k.org>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Daniel Palmer <daniel@...f.com>, stable@...nel.org,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: wd33c93: Don't use stale scsi_pointer value

Hi Finn,

looks good to me, so:

Reviewed-by: Michael Schmitz <schmitzmic@...il.com>

Cheers,

	Michael


Am 03.10.2024 um 16:29 schrieb Finn Thain:
> From: Daniel Palmer <daniel@...f.com>
>
> A regression was introduced with commit dbb2da557a6a ("scsi: wd33c93: Move
> the SCSI pointer to private command data") which results in an oops in
> wd33c93_intr(). That commit added the scsi_pointer variable and
> initialized it from hostdata->connected. However, during selection,
> hostdata->connected is not yet valid. Fix this by getting the current
> scsi_pointer from hostdata->selecting.
>
> Cc: Daniel Palmer <daniel@...f.com>
> Cc: Michael Schmitz <schmitzmic@...il.com>
> Cc: stable@...nel.org
> Fixes: dbb2da557a6a ("scsi: wd33c93: Move the SCSI pointer to private command data")
> Signed-off-by: Daniel Palmer <daniel@...f.com>
> Co-developed-by: Finn Thain <fthain@...ux-m68k.org>
> Signed-off-by: Finn Thain <fthain@...ux-m68k.org>
> ---
>  drivers/scsi/wd33c93.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/wd33c93.c b/drivers/scsi/wd33c93.c
> index a44b60c9004a..dd1fef9226f2 100644
> --- a/drivers/scsi/wd33c93.c
> +++ b/drivers/scsi/wd33c93.c
> @@ -831,7 +831,7 @@ wd33c93_intr(struct Scsi_Host *instance)
>  		/* construct an IDENTIFY message with correct disconnect bit */
>
>  		hostdata->outgoing_msg[0] = IDENTIFY(0, cmd->device->lun);
> -		if (scsi_pointer->phase)
> +		if (WD33C93_scsi_pointer(cmd)->phase)
>  			hostdata->outgoing_msg[0] |= 0x40;
>
>  		if (hostdata->sync_stat[cmd->device->id] == SS_FIRST) {
>