linux-kernel - Re: [RFC 4/5] cxl: Set type of region to that of the first endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5fmng5z.fsf@yhuang6-desk2.ccr.corp.intel.com>
Date: Thu, 03 Oct 2024 09:12:08 +0800
From: "Huang, Ying" <ying.huang@...el.com>
To: Ben Cheatham <benjamin.cheatham@....com>
Cc: <linux-cxl@...r.kernel.org>,  <linux-kernel@...r.kernel.org>,  "Jonathan
 Cameron" <Jonathan.Cameron@...wei.com>,  Davidlohr Bueso
 <dave@...olabs.net>,  Alison Schofield <alison.schofield@...el.com>,
  Vishal Verma <vishal.l.verma@...el.com>,  Ira Weiny
 <ira.weiny@...el.com>,  Alejandro Lucero <alucerop@....com>,  Dan Williams
 <dan.j.williams@...el.com>,  Dave Jiang <dave.jiang@...el.com>
Subject: Re: [RFC 4/5] cxl: Set type of region to that of the first endpoint

Hi, Ben,

Ben Cheatham <benjamin.cheatham@....com> writes:

> On 9/24/24 9:46 PM, Huang Ying wrote:

[snip]

>> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
>> index 2dee78e9b90c..5633b7316cb3 100644
>> --- a/drivers/cxl/core/port.c
>> +++ b/drivers/cxl/core/port.c
>> @@ -139,6 +139,8 @@ static ssize_t target_type_show(struct device *dev,
>>  		return sysfs_emit(buf, "accelerator\n");
>>  	case CXL_DECODER_EXPANDER:
>>  		return sysfs_emit(buf, "expander\n");
>> +	default:
>> +		break;
>
> You can drop this imo. It doesn't change anything functionally considering
> the break is immediately followed by a return.

Sorry, I cannot do that.  Otherwise, there will be build error.

> Thanks,
> Ben
>
>>  	}
>>  	return -ENXIO;
>>  }

[snip]

--
Best Regards,
Huang, Ying