linux-kernel - Re: [PATCH v2 2/2] irqchip/gic-v3-its: Rely on genpool alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zv5m9p6aNQiapov4@arm.com>
Date: Thu, 3 Oct 2024 10:42:14 +0100
From: Catalin Marinas <catalin.marinas@....com>
To: Steven Price <steven.price@....com>
Cc: Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Will Deacon <will@...nel.org>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Michael Kelley <mhklinux@...look.com>
Subject: Re: [PATCH v2 2/2] irqchip/gic-v3-its: Rely on genpool alignment

On Wed, Oct 02, 2024 at 03:16:30PM +0100, Steven Price wrote:
> its_create_device() over-allocated by ITS_ITT_ALIGN - 1 bytes to ensure
> that an aligned area was available within the allocation. The new
> genpool allocator has its min_alloc_order set to
> get_order(ITS_ITT_ALIGN) so all allocations from it should be
> appropriately aligned.
> 
> Remove the over-allocation from its_create_device() and alignment from
> its_build_mapd_cmd().
> 
> Tested-by: Will Deacon <will@...nel.org>
> Reviewed-by: Marc Zyngier <maz@...nel.org>
> Signed-off-by: Steven Price <steven.price@....com>

Reviewed-by: Catalin Marinas <catalin.marinas@....com>