linux-kernel - Re: [PATCH] PCI: controller: Switch back to struct platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tdxrmmqyzcufupnwkdbg7lwgadizm7v3lxjirykijbml7x54ze@upbdzycdsilm>
Date: Thu, 3 Oct 2024 12:17:08 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc: linux-pci@...r.kernel.org, vigneshr@...com, s-vadapalli@...com, 
	lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org, robh@...nel.org, 
	bhelgaas@...gle.com, jingoohan1@...il.com, krzk@...nel.org, alim.akhtar@...sung.com, 
	shawn.guo@...aro.org, songxiaowei@...ilicon.com, marek.vasut+renesas@...il.com, 
	yoshihiro.shimoda.uh@...esas.com, thierry.reding@...il.com, jonathanh@...dia.com, 
	thomas.petazzoni@...tlin.com, pali@...nel.org, florian.fainelli@...adcom.com, 
	angelogioacchino.delregno@...labora.com, ryder.lee@...iatek.com, heiko@...ech.de, 
	kevin.xie@...rfivetech.com, kishon@...nel.org, dlemoal@...nel.org, shawn.lin@...k-chips.com, 
	linux-rockchip@...ts.infradead.org, linux-tegra@...r.kernel.org, linux-samsung-soc@...r.kernel.org, 
	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: controller: Switch back to struct
 platform_driver::remove()

Hello,

I found this patch in next as 712359cb5e9d9553c1383fc5005593aa1988efc4.

While rebasing my patches with the same purpose I found that this patch
handled the indention differently than I did for two files:

On Mon, Sep 23, 2024 at 08:57:06AM +0200, Sergio Paracuellos wrote:
> diff --git a/drivers/pci/controller/pcie-altera.c b/drivers/pci/controller/pcie-altera.c
> index ef73baefaeb9..b921bbb4de80 100644
> --- a/drivers/pci/controller/pcie-altera.c
> +++ b/drivers/pci/controller/pcie-altera.c
> @@ -817,7 +817,7 @@ static void altera_pcie_remove(struct platform_device *pdev)
>  
>  static struct platform_driver altera_pcie_driver = {
>  	.probe		= altera_pcie_probe,
> -	.remove_new	= altera_pcie_remove,
> +	.remove	= altera_pcie_remove,
>  	.driver = {
>  		.name	= "altera-pcie",
>  		.of_match_table = altera_pcie_of_match,

here indention is inconsistent already before, I replaced the tabs after
".probe" by a single space (and after .remove, too).

> [...]
> diff --git a/drivers/pci/controller/pcie-hisi-error.c b/drivers/pci/controller/pcie-hisi-error.c
> index ad9d5ffcd9e3..cb5fcfe032d1 100644
> --- a/drivers/pci/controller/pcie-hisi-error.c
> +++ b/drivers/pci/controller/pcie-hisi-error.c
> @@ -317,7 +317,7 @@ static struct platform_driver hisi_pcie_error_handler_driver = {
>  		.acpi_match_table = hisi_pcie_acpi_match,
>  	},
>  	.probe		= hisi_pcie_error_handler_probe,
> -	.remove_new	= hisi_pcie_error_handler_remove,
> +	.remove	= hisi_pcie_error_handler_remove,
>  };
>  module_platform_driver(hisi_pcie_error_handler_driver);
>  

Here I added another tab after ".remove".

> [...]

Also the patch missed to adapt drivers/pci/controller/pcie-xilinx-nwl.c.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)