linux-kernel - [PATCH] dmaengine: ppc4xx: Call of_node_put(np) only once in ppc440spe_adma_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4f999e1b-9c10-453c-b68b-1495861d425c@web.de>
Date: Thu, 3 Oct 2024 12:26:25 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: dmaengine@...r.kernel.org, Amit Vadhavana <av2082000@...il.com>,
 Anatolij Gustschin <agust@...x.de>, Dan Williams <dan.j.williams@...el.com>,
 Dave Jiang <dave.jiang@...el.com>, Fenghua Yu <fenghua.yu@...el.com>,
 Kees Cook <kees@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Yuri Tikhonov <yur@...raft.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: [PATCH] dmaengine: ppc4xx: Call of_node_put(np) only once in
 ppc440spe_adma_setup_irqs()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Thu, 3 Oct 2024 11:40:06 +0200

An of_node_put(np) call was immediately used after a null pointer check
for an of_iomap() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/dma/ppc4xx/adma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
index 7b78759ac734..25d5ec028d68 100644
--- a/drivers/dma/ppc4xx/adma.c
+++ b/drivers/dma/ppc4xx/adma.c
@@ -3938,13 +3938,13 @@ static int ppc440spe_adma_setup_irqs(struct ppc440spe_adma_device *adev,
 			goto err_req2;
 		}
 		adev->i2o_reg = of_iomap(np, 0);
+		of_node_put(np);
 		if (!adev->i2o_reg) {
 			pr_err("%s: failed to map I2O registers\n", __func__);
-			of_node_put(np);
 			ret = -EINVAL;
 			goto err_req2;
 		}
-		of_node_put(np);
+
 		/* Unmask 'CS FIFO Attention' interrupts and
 		 * enable generating interrupts on errors
 		 */
--
2.46.1