linux-kernel - Re: [PATCH 2/2] dt-bindings: display: bridge: sil,sii9022: Add data-lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d28be8e9-b235-43e0-aaed-dd65a87c5797@phytec.de>
Date: Thu, 3 Oct 2024 13:56:24 +0200
From: Wadim Egorov <w.egorov@...tec.de>
To: Krzysztof Kozlowski <krzk@...nel.org>, <andrzej.hajda@...el.com>,
	<neil.armstrong@...aro.org>, <rfoss@...nel.org>
CC: <Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
	<jernej.skrabec@...il.com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
	<simona@...ll.ch>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<bbrezillon@...nel.org>, <conor+dt@...nel.org>, <krzk+dt@...nel.org>,
	<robh@...nel.org>, <upstream@...ts.phytec.de>
Subject: Re: [PATCH 2/2] dt-bindings: display: bridge: sil,sii9022: Add
 data-lines



Am 03.10.24 um 12:03 schrieb Krzysztof Kozlowski:
> On 03/10/2024 10:20, Wadim Egorov wrote:
>> The SI9022 HDMI transmitter can be configured with 16, 18, or 24 input
>> data lines. This commit introduces the data-lines property to the input
> 
> lines? lanes? What are lines? like pins?

Yes, "lines" in this context refers to the number of pins used for the 
input pixel data bus, which can support 16, 18, or 24-bit wide data 
buses. These are parallel data lines (or pins) that carry uncompressed 
digital video to the HDMI transmitter.

> 
>> endpoint, specifying the number of parallel RGB input pins connected
>> to the transmitter.
>>
>> Signed-off-by: Wadim Egorov <w.egorov@...tec.de>
>> ---
>>   .../bindings/display/bridge/sil,sii9022.yaml        | 13 ++++++++++++-
>>   1 file changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml
>> index 5a69547ad3d7..24306f8eb107 100644
>> --- a/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml
>> +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml
>> @@ -81,9 +81,20 @@ properties:
>>   
>>       properties:
>>         port@0:
>> -        $ref: /schemas/graph.yaml#/properties/port
>> +        unevaluatedProperties: false
>> +        $ref: /schemas/graph.yaml#/$defs/port-base
>>           description: Parallel RGB input port
>>   
>> +        properties:
>> +          endpoint:
>> +            $ref: /schemas/graph.yaml#/$defs/endpoint-base
>> +            unevaluatedProperties: false
>> +
>> +            properties:
>> +              data-lines:
> 
> No, this will confuse everyone. Considering lack of description how
> anyone would figure out what this means?

I guess from working with the hardware/reference manual and using this chip?

I don't think it is overly confusing, especially since the port is 
already described as the "Parallel RGB input port" which clearly implies 
the use of pins for data transmission.

I am open to other suggestions if you believe a different name would 
improve clarity.

Btw, bridge/toshiba,tc358768.yaml, which performs a similar function, 
also uses the term data-lines.

Regards,
Wadim

> 
> I don't know much about RGB parallel port to advice how this should be
> called. Can you describe the hardware more?
> 
>> +                $ref: /schemas/types.yaml#/definitions/uint32
>> +                enum: [ 16, 18, 24 ]
>> +
>>         port@1:
>>           $ref: /schemas/graph.yaml#/properties/port
>>           description: HDMI output port
> 
> Best regards,
> Krzysztof
>