linux-kernel - Re: [PATCH v1] ps3: Correct some typos in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f14cd0d3-5e27-47a0-9673-f176ede7e3ac@csgroup.eu>
Date: Thu, 3 Oct 2024 14:59:20 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Shen Lichuan <shenlichuan@...o.com>, geoff@...radead.org,
 mpe@...erman.id.au
Cc: npiggin@...il.com, naveen@...nel.org, maddy@...ux.ibm.com,
 linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
 opensource.kernel@...o.com
Subject: Re: [PATCH v1] ps3: Correct some typos in comments



Le 30/09/2024 à 04:32, Shen Lichuan a écrit :
> [Vous ne recevez pas souvent de courriers de shenlichuan@...o.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> Fixed some confusing typos that were currently identified with codespell,
> the details are as follows:

What is confusing in those typos ? Sure they are typos but I can't see 
any confusing meaning behind. There is no ambiguity.

I would agree if for instance you had "live" instead of "leave", but 
here I can't see any alternative meaning.

> 
> -in the code comments:
> drivers/ps3/ps3-lpm.c:94: rigths ==> rights
> drivers/ps3/ps3-sys-manager.c:365: acnowledge ==> acknowledge
> drivers/ps3/ps3-vuart.c:470: remaning ==> remaining
> drivers/ps3/ps3-vuart.c:471: transmision ==> transmission
> drivers/ps3/sys-manager-core.c:15: Staticly ==> Statically
> 
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>
> ---
>   drivers/ps3/ps3-lpm.c          | 2 +-
>   drivers/ps3/ps3-sys-manager.c  | 2 +-
>   drivers/ps3/ps3-vuart.c        | 4 ++--
>   drivers/ps3/sys-manager-core.c | 2 +-
>   4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/ps3/ps3-lpm.c b/drivers/ps3/ps3-lpm.c
> index 200ad8751860..188ae2572674 100644
> --- a/drivers/ps3/ps3-lpm.c
> +++ b/drivers/ps3/ps3-lpm.c
> @@ -91,7 +91,7 @@ struct ps3_lpm_shadow_regs {
>    * struct ps3_lpm_priv - Private lpm device data.
>    *
>    * @open: An atomic variable indicating the lpm driver has been opened.
> - * @rights: The lpm rigths granted by the system policy module.  A logical
> + * @rights: The lpm rights granted by the system policy module.  A logical
>    *  OR of enum ps3_lpm_rights.
>    * @node_id: The node id of a BE processor whose performance monitor this
>    *  lpar has the right to use.
> diff --git a/drivers/ps3/ps3-sys-manager.c b/drivers/ps3/ps3-sys-manager.c
> index ad8ef59dea34..ab798b52910e 100644
> --- a/drivers/ps3/ps3-sys-manager.c
> +++ b/drivers/ps3/ps3-sys-manager.c
> @@ -362,7 +362,7 @@ static int ps3_sys_manager_send_request_shutdown(
>    * ps3_sys_manager_send_response - Send a 'response' to the system manager.
>    * @status: zero = success, others fail.
>    *
> - * The guest sends this message to the system manager to acnowledge success or
> + * The guest sends this message to the system manager to acknowledge success or
>    * failure of a command sent by the system manager.
>    */
> 
> diff --git a/drivers/ps3/ps3-vuart.c b/drivers/ps3/ps3-vuart.c
> index 6328abd51ffa..5cb92535a4a1 100644
> --- a/drivers/ps3/ps3-vuart.c
> +++ b/drivers/ps3/ps3-vuart.c
> @@ -467,8 +467,8 @@ struct list_buffer {
>    *
>    * If the port is idle on entry as much of the incoming data is written to
>    * the port as the port will accept.  Otherwise a list buffer is created
> - * and any remaning incoming data is copied to that buffer.  The buffer is
> - * then enqueued for transmision via the transmit interrupt.
> + * and any remaining incoming data is copied to that buffer.  The buffer is
> + * then enqueued for transmission via the transmit interrupt.
>    */
> 
>   int ps3_vuart_write(struct ps3_system_bus_device *dev, const void *buf,
> diff --git a/drivers/ps3/sys-manager-core.c b/drivers/ps3/sys-manager-core.c
> index e061b7d0632b..f50032ad9702 100644
> --- a/drivers/ps3/sys-manager-core.c
> +++ b/drivers/ps3/sys-manager-core.c
> @@ -12,7 +12,7 @@
>   #include <asm/ps3.h>
> 
>   /**
> - * Staticly linked routines that allow late binding of a loaded sys-manager
> + * Statically linked routines that allow late binding of a loaded sys-manager
>    * module.
>    */
> 
> --
> 2.17.1
>