linux-kernel - Re: [PATCH] rust: kunit: use C-string literals to clean warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kQ+E5-qQ9X8UdgcBN_P=7JYHo6Ft8rLNRwAXmxbMyeMA@mail.gmail.com>
Date: Thu, 3 Oct 2024 15:02:54 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Gary Guo <gary@...yguo.net>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH] rust: kunit: use C-string literals to clean warning

On Sat, Sep 28, 2024 at 8:36 PM Gary Guo <gary@...yguo.net> wrote:
>
> Note that the cast actually need to be re-introduced instead of
> cleaned-up -- `c"".as_ptr()` returns `core::ffi::c_char` which might be
> signed, while after my series `*const u8` is expected by `printf`.

Ah, right, in your series `bindgen` will point to the new one while
the method will return the `core::ffi` one which might be still `i8`
in some targets.

It would be nice to get a way to modify the target for `u8`, i.e.
`-Cunsigned-char` or a "target modifier" or similar.

Added an entry with some links in our `rustc` list at
https://github.com/Rust-for-Linux/linux/issues/355.

Cheers,
Miguel