linux-kernel - Re: [PATCH v2 3/4] iio: adc: Add support for the GE HealthCare PMC ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdc27a53-281d-41d7-a9b5-196f2650c468@baylibre.com>
Date: Thu, 3 Oct 2024 08:39:54 -0500
From: David Lechner <dlechner@...libre.com>
To: Herve Codina <herve.codina@...tlin.com>,
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Ian Ray <ian.ray@...ealthcare.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 3/4] iio: adc: Add support for the GE HealthCare PMC
 ADC

On 10/3/24 6:46 AM, Herve Codina wrote:
> The GE HealthCare PMC Analog to Digital Converter (ADC) is a 16-Channel
> (voltage and current), 16-Bit ADC with an I2C Interface.
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> ---

...


> +
> +static int pmc_adc_probe(struct i2c_client *client)
> +{
> +	struct iio_dev *indio_dev;
> +	struct pmc_adc *pmc_adc;
> +	struct clk *clk;
> +	s32 val;
> +	int ret;
> +
> +	ret = devm_regulator_bulk_get_enable(&client->dev, ARRAY_SIZE(pmc_adc_regulator_names),
> +					     pmc_adc_regulator_names);
> +	if (ret)
> +		return dev_err_probe(&client->dev, ret, "Failed to get regulators\n");
> +
> +	clk = devm_clk_get_optional_enabled(&client->dev, "osc");
> +	if (IS_ERR(clk))
> +		return dev_err_probe(&client->dev, PTR_ERR(clk), "Failed to get osc clock\n");
> +
> +	indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*pmc_adc));
> +	if (!indio_dev)
> +		return -ENOMEM;
> +
> +	pmc_adc = iio_priv(indio_dev);
> +	pmc_adc->client = client;
> +
> +	val = i2c_smbus_read_byte_data(pmc_adc->client, PMC_ADC_CMD_REQUEST_PROTOCOL_VERSION);
> +	if (val < 0)
> +		return dev_err_probe(&client->dev, val, "Failed to get protocol version\n");
> +
> +	if (val != 0x01)
> +		return dev_err_probe(&client->dev, -EINVAL,
> +				     "Unsupported protocol version 0x%02x\n", val);
> +
> +	indio_dev->name = "pmc_adc";
> +	indio_dev->info = &pmc_adc_info;
> +	indio_dev->channels = pmc_adc_channels;
> +	indio_dev->num_channels = ARRAY_SIZE(pmc_adc_channels);

I don't think the core code actually checks this, but for
correctness we should add:

	indio_dev->modes = INDIO_DIRECT_MODE;

> +
> +	return devm_iio_device_register(&client->dev, indio_dev);
> +}
> +

With that...

Reviewed-by: David Lechner <dlechner@...libre.com>