linux-kernel - Re: [PATCH net] net: add inline annotation to fix the build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAjsZQxEKLZd-fQdRiu68uX6Kg4opW4wsQRaLcKyfnQ+UyO+vw@mail.gmail.com>
Date: Thu, 3 Oct 2024 22:56:59 +0900
From: Moon Yeounsu <yyyynoom@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	linux@...ssschuh.net, j.granados@...sung.com, judyhsiao@...omium.org, 
	James.Z.Li@...l.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net] net: add inline annotation to fix the build warning

On Wed, Oct 2, 2024 at 11:41 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Wed, Oct 2, 2024 at 3:47 PM Moon Yeounsu <yyyynoom@...il.com> wrote:
> >
> > Moon is stupid. He doesn't understand what's going on. It makes me upset.
> >
> > https://lore.kernel.org/netdev/20240919145609.GF1571683@kernel.org/
> >
> > Simon did the best effort for him, but he didn't remember that.
> >
> > Please don't reply to this careless patch.
> >
> > Replies to me to remember all the maintainer's dedication and thoughtfulness and to take this to heart.
> >
> > Before I send the patch, I'll check it again and again. And fix the subject `net` to `net-next`.
> >
> > I'm very very disappointed to myself :(
>
> LOCKDEP is more powerful than sparse, I would not bother with this at all.

Totally agree with that. `Sparse` has a lot of problems derived from its nature.
And It is too annoying to silence the warning message. I know that
this patch just fixes for a fix. (What a trivial?)
But, even though `LOCKDEP` is more powerful than `Sparse`, that can't
be the reason to ignore the warning message.

It is only my opinion and this topic may be outside of the net
subsystem. Please don't be offended by my words and ignorance. I don't
want to make a problem, rather want to fix a problem.
If there's no reason to use `Sparse`, then, how about just removing it
from the kernel? If It can't, we have to make Sparse more useful at
least make to have to care about this warning message.

> LOCKDEP is more powerful than sparse, I would not bother with this at all.

Leastways, This sentence is irrational in my view. Let me know, world!