linux-kernel - Re: [RESEND PATCH] mm: Move set_pxd_safe() helpers from generic to platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <773d1ac3-51df-4467-9e85-9a3746398dce@intel.com>
Date: Thu, 3 Oct 2024 07:09:27 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Anshuman Khandual <anshuman.khandual@....com>, linux-mm@...ck.org,
 akpm@...ux-foundation.org, paul.walmsley@...ive.com,
 dave.hansen@...ux.intel.com
Cc: Palmer Dabbelt <palmer@...belt.com>, Thomas Gleixner
 <tglx@...utronix.de>, David Hildenbrand <david@...hat.com>,
 Ryan Roberts <ryan.roberts@....com>, x86@...nel.org,
 linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] mm: Move set_pxd_safe() helpers from generic to
 platform

On 10/2/24 21:48, Anshuman Khandual wrote:
> set_pxd_safe() helpers that serve a specific purpose for both x86 and riscv
> platforms, do not need to be in the common memory code. Otherwise they just
> unnecessarily make the common API more complicated. This moves the helpers
> from common code to platform instead.

I looked into the x86 side a bit.  I'm pretty sure we can just remove
the _safe variants.  All they do is spew warnings that don't seem to be
doing any good.  They're not really safer in any meaningful way.

I've got a series cooked up to zap them, but I need to get some eyeballs
on it.

But if Andrew wants to pick this up any carry it in the meantime since
it's cross-arch I'm fine with it:

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>