linux-kernel - Re: [PATCH] mm: percpu: fix typo to pcpu_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3cbe26aa-1f6c-48c3-ad5e-203c98333dab@suse.cz>
Date: Thu, 3 Oct 2024 16:49:13 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Jeongjun Park <aha310510@...il.com>, dennis@...nel.org, tj@...nel.org,
 cl@...ux.com
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
 Suren Baghdasaryan <surenb@...gle.com>
Subject: Re: [PATCH] mm: percpu: fix typo to pcpu_alloc_noprof() description

On 9/24/24 17:24, Jeongjun Park wrote:
> In the previous commit, the function name was changed from pcpu_alloc to 
> pcpu_alloc_noprof , but the function description was not changed accordingly.
> The function name should be changed to pcpu_alloc_noprof in the description
> as well.
> 
> Signed-off-by: Jeongjun Park <aha310510@...il.com>

See 51a7bf0238c2 ("scripts/kernel-doc: drop "_noprof" on function prototypes")

So in fact we can't do that now (as the bot reply suggests), even if
pcpu_alloc() doesnt seem to exist - all the hooks wrapping
pcpu_alloc_noprof() are named differently?

> ---
>  mm/percpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/percpu.c b/mm/percpu.c
> index 20d91af8c033..7081b0ed59d6 100644
> --- a/mm/percpu.c
> +++ b/mm/percpu.c
> @@ -1726,7 +1726,7 @@ static void pcpu_alloc_tag_free_hook(struct pcpu_chunk *chunk, int off, size_t s
>  #endif
>  
>  /**
> - * pcpu_alloc - the percpu allocator
> + * pcpu_alloc_noprof - the percpu allocator
>   * @size: size of area to allocate in bytes
>   * @align: alignment of area (max PAGE_SIZE)
>   * @reserved: allocate from the reserved chunk if available
> --
>