linux-kernel - Re: [PATCH 1/3] dma-buf: replace symbolic permission S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOuPNLg1=YCUFXW-76A_gZm_PE1MFSugNvg3dEdkfujXV_5Zfw@mail.gmail.com>
Date: Thu, 3 Oct 2024 22:17:22 +0530
From: Pintu Agarwal <pintu.ping@...il.com>
To: Sumit Semwal <sumit.semwal@...aro.org>
Cc: Pintu Kumar <quic_pintu@...cinc.com>, christian.koenig@....com, 
	linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org, joe@...ches.com, 
	skhan@...uxfoundation.org
Subject: Re: [PATCH 1/3] dma-buf: replace symbolic permission S_IRUGO with
 octal 0444

Hi Sumit,

On Thu, 3 Oct 2024 at 12:27, Sumit Semwal <sumit.semwal@...aro.org> wrote:
>
> Hello Pintu,
>
> On Tue, 1 Oct 2024 at 23:16, Pintu Kumar <quic_pintu@...cinc.com> wrote:
> >
> > Symbolic permissions are not preferred, instead use the octal.
> > Also, fix other warnings/errors as well for cleanup.
> >
> > WARNING: Block comments use * on subsequent lines
> > +       /* only support discovering the end of the buffer,
> > +          but also allow SEEK_SET to maintain the idiomatic
> >
> > WARNING: Block comments use a trailing */ on a separate line
> > +          SEEK_END(0), SEEK_CUR(0) pattern */
> >
> > WARNING: Block comments use a trailing */ on a separate line
> > +        * before passing the sgt back to the exporter. */
> >
> > ERROR: "foo * bar" should be "foo *bar"
> > +static struct sg_table * __map_dma_buf(struct dma_buf_attachment *attach,
> >
> > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
> > +       d = debugfs_create_file("bufinfo", S_IRUGO, dma_buf_debugfs_dir,
> >
> > total: 1 errors, 4 warnings, 1746 lines checked
> >
> > Signed-off-by: Pintu Kumar <quic_pintu@...cinc.com>
>
> Thanks for this patch - could you please also mention in the commit
> log how did you find this? It looks like you ran checkpatch, but it's
> not clear from the commit log.
>
Thanks for your review.
Sure. Yes, it was found while using the checkpatch.
I tried to put "checkpatch fixes" in the commit header but the tool
did not allow me.
So, I removed it.
But I think I can add that in the commit log.

> Since this patch does multiple things related to checkpatch warnings
> (change S_IRUGO to 0444, comments correction, function declaration
> correction), can I please ask you to change the commit title to also
> reflect that?
>
ok sure. Last time I tried to mention "fix checkpatch warnings" in a
general way,
but the tool itself catches it and throws another warning.
So, I chose the major fix as the commit header and combined others, instead
of raising 3 different patches.
Let me try to put the same as you mentioned above.

I will correct these and send v2 in a different mail.

Thanks.