linux-kernel - Re: [PATCH 3/3] zsmalloc: replace kmap_atomic with kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOuPNLiJHRL+7B9FkmK_x3gcjwrAfNaRR6mrYy-AwT_M5yaiww@mail.gmail.com>
Date: Thu, 3 Oct 2024 22:25:38 +0530
From: Pintu Agarwal <pintu.ping@...il.com>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Pintu Kumar <quic_pintu@...cinc.com>, minchan@...nel.org, akpm@...ux-foundation.org, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org, joe@...ches.com, 
	skhan@...uxfoundation.org
Subject: Re: [PATCH 3/3] zsmalloc: replace kmap_atomic with kmap_local_page

Hi Sergey,

On Wed, 2 Oct 2024 at 08:48, Sergey Senozhatsky
<senozhatsky@...omium.org> wrote:
>
> On (24/10/01 23:23), Pintu Kumar wrote:
> > The use of kmap_atomic/kunmap_atomic is deprecated.
> > Replace it will kmap_local_page/kunmap_local all over the place.
> > Also fix SPDX missing license header.
> >
> > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> >
> > WARNING: Deprecated use of 'kmap_atomic', prefer 'kmap_local_page' instead
> > +               vaddr = kmap_atomic(page);
> >
>
> Can you also update the comments (that mention kmap/kunmap atomic)?
>
Oh yes, sorry I missed it in the patch.
Thanks for pointing this out.
I will also check Matthew's comment below and fix it together.

Thanks