linux-kernel - Re: [PATCH net-next v4 1/2] dt-bindings: net: ethernet-phy: Add timing-role role property for ethernet PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19207165-1708-4717-9883-19d914aea5c3@lunn.ch>
Date: Thu, 3 Oct 2024 19:05:58 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Divya.Koppera@...rochip.com, hkallweit1@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	f.fainelli@...il.com, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux@...linux.org.uk, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v4 1/2] dt-bindings: net: ethernet-phy: Add
 timing-role role property for ethernet PHYs

On Thu, Oct 03, 2024 at 03:08:09PM +0200, Oleksij Rempel wrote:
> On Thu, Oct 03, 2024 at 02:08:00PM +0200, Andrew Lunn wrote:
> > > > +      - 'force-master': The PHY is forced to operate as a master.
> > > > +      - 'force-slave': The PHY is forced to operate as a slave.
> > > > +      - 'prefer-master': Prefer the PHY to be master but allow negotiation.
> > > > +      - 'prefer-slave': Prefer the PHY to be slave but allow negotiation.
> > > > +
> > > 
> > > I would suggest to use "preferred" instead of "prefer" to be in sync with existing phy library macros.
> > 
> > How does 802.3 name it?
> 
> 802.3 use "Multiport device" for "preferred master" and "single-port device"
> for "preferred slave". We decided to use other wording back in the past
> to avoid confusing and align it with forced master/slave configurations. 

ethtool is preferred, so it would be more consistent with preferred

[Shrug]

	Andrew