linux-kernel - Re: [PATCH 0/2] ti-cpufreq: AM62: Backward compatibility for syscon and update offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241003171349.lphhvxy7lgwwdhay@marital>
Date: Thu, 3 Oct 2024 12:13:49 -0500
From: Nishanth Menon <nm@...com>
To: Dhruva Gole <d-gole@...com>
CC: "Rafael J. Wysocki" <rafael@...nel.org>,
        Viresh Kumar
	<viresh.kumar@...aro.org>, <linux-pm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Bryan Brattlof <bb@...com>,
        Andrew Davis
	<afd@...com>
Subject: Re: [PATCH 0/2] ti-cpufreq: AM62: Backward compatibility for syscon
 and update offsets

On 15:02-20240930, Dhruva Gole wrote:
> With the Silicon revision being taken directly from socinfo, there's no
> longer any need for reading any SOC register for revision from this driver.
> Hence, we do not require any rev_offset for AM62 family of devices.
> 
> Also, maintain the backward compatibility with old devicetree, and hence
> add condition to handle the case where we have the zero offset such that we
> don't end up reading the wrong register offset in new AM625 DTs whenever we fix
> them up.
> 
> These patches have been in discussion as part of another series, which is now
> being split up as per discussions with Nishanth. Ref. the following link for
> more context on the same:
> https://lore.kernel.org/all/20240926-ti-cpufreq-fixes-v5-v7-0-3c94c398fe8f@ti.com/
> 
> **DEPENDS ON:**
> "mfd: syscon: Use regmap max_register_is_0 as needed"
> https://lore.kernel.org/linux-arm-kernel/20240903184710.1552067-1-nm@ti.com/
> 
> This series has been tested on AM625 on top of above patch:
> https://gist.github.com/DhruvaG2000/40b80cc04a9ac90c86445d6e67ece4cb
> 
> Signed-off-by: Dhruva Gole <d-gole@...com>
> ---
> Dhruva Gole (2):
>       cpufreq: ti-cpufreq: Allow backward compatibility for efuse syscon
>       cpufreq: ti-cpufreq: Remove revision offsets in AM62 family
> 
>  drivers/cpufreq/ti-cpufreq.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> ---
> base-commit: cea5425829f77e476b03702426f6b3701299b925
> change-id: 20240930-b4-ti-cpufreq-am62-quirk-46242e3daa2b
> 
> Best regards,
> -- 
> Dhruva Gole <d-gole@...com>
> 

Reviewed-by: Nishanth Menon <nm@...com>

Viresh,

The existing device tree works with this changes even without the
dependency being merged. DT update can happen in the next window once
the pieces are merged together.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D